Add Button::from_label
#1226
Merged
Add Button::from_label
#1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ForLoveOfCats
added
enhancement
ForLoveOfCats
force-pushed
the
ButtonFromLabel
branch
from
3f7cc72
to
09ca94f
Compare
|
Something's going nuts with the nightly CI, it appears to be failing to install the toolchain |
|
Probably fallout from https://rust-lang.github.io/rustup-components-history/x86_64-apple-darwin.html ; our CI scripts are not robust against failures there. |
cmyr
approved these changes
Sep 12, 2020
ForLoveOfCats
force-pushed
the
ButtonFromLabel
branch
from
09ca94f
to
70541f5
Compare
ForLoveOfCats
force-pushed
the
ButtonFromLabel
branch
from
70541f5
to
b9bf093
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Button I wanted to be able to use the builder fns on Label. Rather than stub them all on Button and try to keep it up to date with Label as new fns are added it felt much simpler and cleaner to simply allow constructing a Button with a provided Label. There is no corresponding
dynamic_from_label, one can useLabel::dynamicto achieve that.