Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements Data trait for i128 and u128 #1214

Merged
merged 4 commits into from
Sep 11, 2020
Merged

Implements Data trait for i128 and u128 #1214

merged 4 commits into from
Sep 11, 2020

Conversation

koutoftimer
Copy link
Contributor

Relative to #1213

@ForLoveOfCats ForLoveOfCats linked an issue Sep 11, 2020 that may be closed by this pull request
Data trait not implemented for u128 #1213
Closed
@ForLoveOfCats ForLoveOfCats added the enhancement adds or requests a new feature label Sep 11, 2020
ForLoveOfCats
ForLoveOfCats approved these changes Sep 11, 2020
View reviewed changes
Copy link
Collaborator

@ForLoveOfCats ForLoveOfCats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me

@ForLoveOfCats
Copy link
Collaborator

ForLoveOfCats commented Sep 11, 2020 •
edited
Loading

This should probably get a changelog entry

ForLoveOfCats
ForLoveOfCats requested changes Sep 11, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@koutoftimer
Fixes typo in Changelog
29a473a 
Changes changelog according to contribution guidelines.
@koutoftimer
Fixes links in changelog
db5f797
ForLoveOfCats
ForLoveOfCats approved these changes Sep 11, 2020
View reviewed changes
Copy link
Collaborator

@ForLoveOfCats ForLoveOfCats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@ForLoveOfCats ForLoveOfCats merged commit fae1353 into linebender:master Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForLoveOfCats ForLoveOfCats ForLoveOfCats approved these changes

Assignees
No one assigned
Labels
enhancement adds or requests a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data trait not implemented for u128
2 participants
@koutoftimer @ForLoveOfCats