Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-click mouse events on Windows #1157

Merged
merged 2 commits into from
Aug 26, 2020
Merged

Multi-click mouse events on Windows #1157

merged 2 commits into from
Aug 26, 2020

Conversation

raphlinus
Copy link
Contributor

This is a partial fix for #859, addressing only the Windows platform.

The point of this PR is to get double-click working. It does not address other parts of that issue, including:

  • Reporting click count on mouse-up.
  • Being pickier about incrementing count when multiple buttons are involved.
  • Any change at all to platforms other than Windows.

That said, it is sensitive to the platform setting.

This is a partial fix for #859, addressing only the Windows platform.
But in general it should represent how we want to handle this.
@luleyleo luleyleo added S-needs-review waits for review shell/win concerns the Windows backend labels Aug 25, 2020
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't run this but code-level it looks good, and will be nice to get this working!

@raphlinus raphlinus merged commit 8cdb145 into master Aug 26, 2020
@raphlinus raphlinus deleted the win_multi_click branch August 26, 2020 20:52
@xStrom xStrom removed the S-needs-review waits for review label Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shell/win concerns the Windows backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants