Fix switch widget toggle animation being window refresh rate dependent #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ForLoveOfCats
added
bug
ForLoveOfCats
force-pushed
the
SwitchAnimUseInterval
branch
from
f405d3c
to
36e8baf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The time in seconds that the animation should take is specified by the
SWITCH_CHANGE_TIMEconstant. I was going to put it in the env but it didn't make sense as currently it is entirely dedicated to theming so I went with a const. The total animation time might appear faster or slower than before, it used to be painfully slow when the refresh rate was 60 hertz and I don't know what refresh rate it was originally tested under so I just tried to go for a value which felt good but wasn't to fast.The knob position is now also clamped.