Wrap EnvScope child in WidgetPod and pass down the new Env during layout. #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary to make debug_paint_layout and debug_widget_id apply to the widget they are called on and not just their descendants.
jneem
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this,
EnvScopewill wrap its child in aWidgetPod.This means that
debug_paint_layoutanddebug_widget_idwill now apply to the widget they are called on (until now it would only apply to "the child's children"). For example calling one of those methods on aButtonwill now work.debug_widget_idwill now show the root widget's id as well, which was not possible before.Also, we've been passing down
envinstead ofnew_envduringWidget::layout, now we are passingnew_env.