Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't panic in the GTK idle handler if already borrowed. #1043

Merged
merged 4 commits into from
Jun 19, 2020
Merged

Don't panic in the GTK idle handler if already borrowed. #1043

merged 4 commits into from
Jun 19, 2020

Conversation

jneem
Copy link
Collaborator

@jneem jneem commented Jun 18, 2020

Fixes #1041.

xStrom
xStrom reviewed Jun 18, 2020
View reviewed changes
Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks decent apart from the changelog.

CHANGELOG.md Outdated Show resolved Hide resolved
@xStrom xStrom added S-needs-review waits for review shell/gtk concerns the GTK backend labels Jun 18, 2020
xStrom
xStrom approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks decent.

@xStrom xStrom removed the S-needs-review waits for review label Jun 19, 2020
@jneem jneem merged commit 1e667dd into linebender:master Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xStrom xStrom xStrom approved these changes

Assignees
No one assigned
Labels
shell/gtk concerns the GTK backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic with file open dialog and ExtEventSink
2 participants
@jneem @xStrom