Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementation of Default for FlexParams is invalid #1708

Closed
andrewhickman opened this issue Apr 9, 2021 · 1 comment · Fixed by #1885
Closed

implementation of Default for FlexParams is invalid #1708

andrewhickman opened this issue Apr 9, 2021 · 1 comment · Fixed by #1885
Labels
maintenance cleans up code or docs

Comments

@andrewhickman
Copy link
Contributor

andrewhickman commented Apr 9, 2021

#1691 added a check to prevent using a flex factor less than or equal to 0.0, but FlexParams has #[derive(Default)] which allows bypassing the check with FlexParams::default().

Should we remove the implemenation or does it make sense to use a value like 1.0?

@cmyr
Copy link
Member

cmyr commented Apr 11, 2021

Great question. Before that patch, passing FlexParams::default() would result in a non-flex child. I think what makes the most sense is to remove the default impl.

@cmyr cmyr added the maintenance cleans up code or docs label Apr 11, 2021
maan2003 added a commit to maan2003/druid that referenced this issue Jul 27, 2021
maan2003 added a commit that referenced this issue Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance cleans up code or docs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants