You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#1691 added a check to prevent using a flex factor less than or equal to 0.0, but FlexParams has #[derive(Default)] which allows bypassing the check with FlexParams::default().
Should we remove the implemenation or does it make sense to use a value like 1.0?
The text was updated successfully, but these errors were encountered:
Great question. Before that patch, passing FlexParams::default() would result in a non-flex child. I think what makes the most sense is to remove the default impl.
#1691 added a check to prevent using a flex factor less than or equal to 0.0, but
FlexParams
has#[derive(Default)]
which allows bypassing the check withFlexParams::default()
.Should we remove the implemenation or does it make sense to use a value like 1.0?
The text was updated successfully, but these errors were encountered: