Skip to content

Commit

Permalink
WidgetPod: change not laid out panic to warning (#1441)
Browse files Browse the repository at this point in the history
* WidgetPod: change not laid out panic to warning

* Update Changelog

Co-authored-by: Maan2003 <[email protected]>
  • Loading branch information
maan2003 and Maan2003 authored Dec 2, 2020
1 parent 4d53282 commit 63d2392
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 3 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ You can find its changes [documented below](#060---2020-06-01).
- Don't drop events while showing file dialogs ([#1302], [#1328] by [@jneem])
- Ensure that `LifeCycle::WidgetAdded` is the first thing a widget sees. ([#1259] by [@finnerale])
- Fix a missed call to `CloseClipboard` on Windows. ([#1410] by [@andrewhickman])

- WidgetPod: change not laid out `debug_panic` to warning ([#1441] by [@Maan2003])
### Visual

- `TextBox` stroke remains inside its `paint_rect`. ([#1007] by [@jneem])
Expand Down Expand Up @@ -357,6 +357,7 @@ Last release without a changelog :(
[@JAicewizard]: https://github.com/JAicewizard
[@andrewhickman]: https://github.com/andrewhickman
[@colinfruit]: https://github.com/colinfruit
[@Maan2003]: https://github.com/Maan2003

[#599]: https://github.com/linebender/druid/pull/599
[#611]: https://github.com/linebender/druid/pull/611
Expand Down Expand Up @@ -542,6 +543,7 @@ Last release without a changelog :(
[#1371]: https://github.com/linebender/druid/pull/1371
[#1410]: https://github.com/linebender/druid/pull/1410
[#1438]: https://github.com/linebender/druid/pull/1438
[#1441]: https://github.com/linebender/druid/pull/1441

[Unreleased]: https://github.com/linebender/druid/compare/v0.6.0...master
[0.6.0]: https://github.com/linebender/druid/compare/v0.5.0...v0.6.0
Expand Down
2 changes: 1 addition & 1 deletion druid/src/core.rs
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,7 @@ impl<T: Data, W: Widget<T>> WidgetPod<T, W> {

// log if we seem not to be laid out when we should be
if self.state.is_expecting_set_origin_call && !event.should_propagate_to_hidden() {
debug_panic!(
log::warn!(
"{:?} received an event ({:?}) without having been laid out. \
This likely indicates a missed call to set_layout_rect.",
ctx.widget_id(),
Expand Down

0 comments on commit 63d2392

Please sign in to comment.