Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename mul_alpha to multiply_alpha? #62

Closed
waywardmonkeys opened this issue Nov 23, 2024 · 0 comments · Fixed by #65
Closed

Rename mul_alpha to multiply_alpha? #62

waywardmonkeys opened this issue Nov 23, 2024 · 0 comments · Fixed by #65
Milestone

Comments

@waywardmonkeys
Copy link
Collaborator

This would make it match the API in Peniko, not just for color but brushes and gradients. Otherwise, Vello might end up with code like:

        skrifa::color::Brush::Solid {
            palette_index,
            alpha,
        } => color_index(cpal, palette_index)
            .map(|it| Brush::Solid(it.mul_alpha(alpha)))
            .unwrap_or(foreground_brush.to_owned().multiply_alpha(alpha)),
@waywardmonkeys waywardmonkeys added this to the 0.2.0 milestone Nov 24, 2024
waywardmonkeys added a commit that referenced this issue Nov 24, 2024
This better fits with the naming scheme in other Linebender
crates.

Fixes #62.
waywardmonkeys added a commit that referenced this issue Nov 24, 2024
This better fits with the naming scheme in other Linebender
crates.

Fixes #62.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant