Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add a env prefix #200

Merged
merged 1 commit into from
May 18, 2021
Merged

chore: Add a env prefix #200

merged 1 commit into from
May 18, 2021

Conversation

kukugi
Copy link
Contributor

@kukugi kukugi commented May 18, 2021

Description

add env prefix for setting viper value useful

related: https://github.com/line/lbm/issues/1269


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@kukugi kukugi requested review from wetcod, egonspace and iproudhon May 18, 2021 07:26
@kukugi kukugi self-assigned this May 18, 2021
@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #200 (8a081c6) into v2/develop (23a0f9e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           v2/develop     #200   +/-   ##
===========================================
  Coverage       53.45%   53.45%           
===========================================
  Files             653      653           
  Lines           47289    47289           
===========================================
  Hits            25280    25280           
  Misses          19157    19157           
  Partials         2852     2852           

@kukugi kukugi merged commit 623dd8c into v2/develop May 18, 2021
@kukugi kukugi deleted the kukugi/v2/chore/env_prefix branch May 18, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants