New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Triage finschia-sdk#200 #22

Closed

Tracked by

0Tech opened this issue Jan 11, 2024 · 1 comment

Closed

Tracked by

Triage finschia-sdk#200 #22

0Tech opened this issue Jan 11, 2024 · 1 comment

Assignees

0Tech commented Jan 11, 2024 •

edited

Loading

The subject of the triage:

chore: Add a env prefix finschia-sdk#200

0Tech mentioned this issue

[Epic]: triage the PRs from Finschia/finschia-sdk #1

Open

96 tasks

github-actions bot added the needs-triage label

0Tech self-assigned this

Author

0Tech commented Jan 16, 2024

The upstream has changed the signature of svrcmd.Execute().
https://github.com/cosmos/cosmos-sdk/blob/d8fb76d4c2671d1bd8ab656a66752091589bb4ad/server/cmd/execute.go#L19
Now, we can remove global const envPrefix entirely. Also, simapp appears using empty ("") env prefix.
https://github.com/cosmos/cosmos-sdk/blob/d8fb76d4c2671d1bd8ab656a66752091589bb4ad/simapp/simd/main.go#L15
Hence, I suggest NOT applying this PR. If someone insists using it, then providing the prefix in Finschia/finschia should be the only way.

0Tech removed the needs-triage label

0Tech closed this as not planned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment