Improve the robustness of old ZooKeeper log removal #1040
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
OldLogRemover
inZooKeeperCommandExecutor
currently catches aThrowable
when deleting an old log or its log blocks. However, it has two issues doing so:Throwable
is way too wide exception to catch. Catching aKeeperException
whose code isNONODE
will be enough.Modifications:
OldLogRemover
now catchesKeeperException
whose code isNONODE
only.deleteLog()
intodeleteLog()
anddeleteLogBlock()
Result:
OldLogRemover
attempts to retrieve a missing log node's metadata, which is not really a critical issue.