Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Node.js version #6029

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Bump Node.js version #6029

merged 1 commit into from
Dec 11, 2024

Conversation

ikhoon
Copy link
Contributor

@ikhoon ikhoon commented Dec 11, 2024

Motivation:

I observed that :docs-client:npmInstall failed frequently. https://github.com/line/armeria/actions/runs/12268833874/job/34231348528?pr=5941#step:9:1028

I don't know the root cause, but it would be worth upgrading to the latest version.
https://nodejs.org/en/about/previous-releases#looking-for-latest-release-of-a-version-branch

Modifications:

  • Node.js 22.3.0 -> 22.10.0
  • NPM 10.8.1 -> 10.9.0

Result:

Fix the failure of npm install

Motivation:

I observed that `:docs-client:npmInstall' failed frequently.
https://github.com/line/armeria/actions/runs/12268833874/job/34231348528?pr=5941#step:9:1028

I don't know the root cause, but it would be worth trying to upgrade the
version to latest versions.
https://nodejs.org/en/about/previous-releases#looking-for-latest-release-of-a-version-branch

Modifications:

- Node.js 22.3.0 -> 22.10.0
- NPM 10.8.1 -> 10.9.0

Result:

Fix the failure of `npm install`
@ikhoon ikhoon merged commit 2d45266 into line:main Dec 11, 2024
13 of 14 checks passed
@ikhoon ikhoon deleted the up-nodejs branch December 11, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants