Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes for 1.31.1 #5995

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Release notes for 1.31.1 #5995

merged 4 commits into from
Nov 22, 2024

Conversation

jrhee17
Copy link
Contributor

@jrhee17 jrhee17 commented Nov 21, 2024

Screenshot 2024-11-21 at 14-47-09 1 31 1 release notes — Armeria release notes

@jrhee17 jrhee17 added this to the 1.31.1 milestone Nov 21, 2024
@ikhoon
Copy link
Contributor

ikhoon commented Nov 21, 2024

Optional) It is unrelated to this PR but should we exclude protobuf-java dependency from protobuf-jackson using exclusions in dependencies.toml? As the result is the same, it is okay to handle it later.

Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

Copy link
Member

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

@jrhee17
Copy link
Contributor Author

jrhee17 commented Nov 22, 2024

should we exclude protobuf-java dependency from protobuf-jackson using exclusions in dependencies.toml

Probably makes more sense in case other modules also try to expose protobuf-jackson in the future. Done

@jrhee17 jrhee17 merged commit ffe68f4 into line:main Nov 22, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants