Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing static constructors to ResponseEntity #5954

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

KarboniteKream
Copy link
Member

Motivation:

This PR adds more static constructors to ResponseEntity to match those available in the deprecated HttpResult.

Modifications:

  • Add static constructors for HttpStatus
  • Replace Void return type with <T> (breaking change)
  • Add missing tests to rxjava3 module

Result:

  • ResponseEntity can now be used the same way that HttpResult was used.

@KarboniteKream KarboniteKream force-pushed the feat/response-entity-constructors branch from 532f864 to 65c4288 Compare October 24, 2024 09:18
Copy link
Member

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks! 😆

@minwoox minwoox added this to the 1.31.0 milestone Oct 24, 2024
Copy link
Contributor

@jrhee17 jrhee17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ikhoon ikhoon merged commit dc26be8 into line:main Nov 5, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants