Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the release note for 1.29.1 #5790

Merged
merged 5 commits into from
Jun 28, 2024
Merged

Add the release note for 1.29.1 #5790

merged 5 commits into from
Jun 28, 2024

Conversation

minwoox
Copy link
Member

@minwoox minwoox commented Jun 28, 2024 •
edited
Loading

No description provided.

@minwoox minwoox added this to the 1.29.1 milestone Jun 28, 2024
jrhee17
jrhee17 approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@jrhee17 jrhee17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 28, 2024 •
edited
Loading

🔍 Build Scan® (commit: 0245c26)

Job name Status Build Scan®
build-windows-latest-jdk-21 ✅ https://ge.armeria.dev/s/6xye6isbpv2yg
build-self-hosted-unsafe-jdk-8 ✅ https://ge.armeria.dev/s/qutlhfv7pifyi
build-self-hosted-unsafe-jdk-21-snapshot-blockhound ✅ https://ge.armeria.dev/s/rwdt4ihfd3o7c
build-self-hosted-unsafe-jdk-17-min-java-17-coverage ✅ https://ge.armeria.dev/s/w7axnyzbuogxg
build-self-hosted-unsafe-jdk-17-min-java-11 ✅ https://ge.armeria.dev/s/qhcrymclcdhfo
build-self-hosted-unsafe-jdk-17-leak ✅ https://ge.armeria.dev/s/j27imtbi5iuc6
build-self-hosted-unsafe-jdk-11 ✅ https://ge.armeria.dev/s/snanb7yuhuzu2
build-macos-12-jdk-21 ✅ https://ge.armeria.dev/s/uqfsrtoegrqm4

ikhoon
ikhoon approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@minwoox
Copy link
Member Author

minwoox commented Jun 28, 2024

screencapture-localhost-8000-release-notes-1-29-1-2024-06-28-11_14_26

@minwoox minwoox merged commit 10919e4 into line:main Jun 28, 2024
15 checks passed
@minwoox minwoox deleted the releaseNote_1.29.1 branch June 28, 2024 02:18
@minwoox
Copy link
Member Author

minwoox commented Jun 28, 2024

Thanks for the review. 😉

minwoox added a commit that referenced this pull request Jun 28, 2024
@minwoox
Add the release note for 1.29.1 (#5790)
b1d886d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhee17 jrhee17 jrhee17 approved these changes

@ikhoon ikhoon ikhoon approved these changes

@trustin trustin trustin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.29.1
Development

Successfully merging this pull request may close these issues.
4 participants
@minwoox @trustin @ikhoon @jrhee17