Prevents the connection from being used immediately when WriteTimeoutException occurs.

[ikhoon]

Motivation:

I got a report from LINE internally where the connection was not
terminated but hung when the VM instance was shut down due to
maintenance of the underlying hypervisor.

operationComplete() was not called for Channel.write() for this
abnormal connection. There was neither a normal response nor a failure
response.

armeria/core/src/main/java/com/linecorp/armeria/client/AbstractHttpRequestHandler.java

Line 126 in f0ec7cb

public final void operationComplete(ChannelFuture future) throws Exception {

As a result, WriteTimeoutException occurred and tried to reset the
connection.

armeria/core/src/main/java/com/linecorp/armeria/client/AbstractHttpRequestHandler.java

Line 331 in f0ec7cb

final void failAndReset(Throwable cause) {

failAndReset() calls Channel.write(Unpooled.EMPTY_BUFFER) first and
then calls Channel.close().

armeria/core/src/main/java/com/linecorp/armeria/internal/common/Http1ObjectEncoder.java

Lines 371 to 374 in f0ec7cb

	final ChannelFuture f = ch.write(Unpooled.EMPTY_BUFFER);
	if (!isWritable(currentId)) {
	f.addListener(ChannelFutureListener.CLOSE);
	}

Since channel.write() does not respond, the connection cannot be
closed.

Modifications:

• Rename HttpSession.deactivate() to markUnacquirable() for clarity.
• Mark the session as unacquirable first before proceeding with the reset
  procedure.
• Unhealthy connections will be cleaned up eventually with
  KeeyAliveHandler by idle timeout.

Result:

Fixed a bug where a connection was reused after WriteTimeoutException
occurred.

[jrhee17]

👍 👍 👍

[github-actions]

🔍 Build Scan® (commit: 8e34185)

Job name	Status	Build Scan®
build-windows-latest-jdk-21	✅	https://ge.armeria.dev/s/e35p2ew6u4chi
build-self-hosted-unsafe-jdk-8	✅	https://ge.armeria.dev/s/ebcup6z3iipyy
build-self-hosted-unsafe-jdk-21-snapshot-blockhound	✅	https://ge.armeria.dev/s/kwxvzz5435pgk
build-self-hosted-unsafe-jdk-17-min-java-17-coverage	✅	https://ge.armeria.dev/s/y6lhnsslvg2cu
build-self-hosted-unsafe-jdk-17-min-java-11	✅	https://ge.armeria.dev/s/ibdrfbmllpcwq
build-self-hosted-unsafe-jdk-17-leak	✅	https://ge.armeria.dev/s/zakho6ovipzwu
build-self-hosted-unsafe-jdk-11	✅	https://ge.armeria.dev/s/qroi27m7prslc
build-macos-12-jdk-21	✅	https://ge.armeria.dev/s/vz4sx6rnboes2

[minwoox]

Looks good, thanks!

[trustin]

👍