Use SELF for Builder Self Type Parameter (part2) #5733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: See line#5684 for the motivation. Modifications: - Refactored builder classes to use the SELF type parameter for the builder's self-referencing methods. Result: - Reduced the need for cumbersome and error-prone method overrides.
ikhoon
approved these changes
Jun 5, 2024
trustin
reviewed
Jun 5, 2024
| @@ -92,6 +92,14 @@ public abstract class AbstractDnsResolverBuilder { | |||
| */ | |||
| protected AbstractDnsResolverBuilder() {} | |||
|
|
|||
| /** | |||
| * Return this. | |||
There was a problem hiding this comment.
Global comment:
Suggested change
| * Return this. | |
| * Returns {@code this}. |
| @@ -36,7 +36,9 @@ | |||
| * @param <T> the response type | |||
| */ | |||
| @UnstableApi | |||
| public abstract class AbstractRuleWithContentBuilder<T extends Response> extends AbstractRuleBuilder { | |||
| public abstract class AbstractRuleWithContentBuilder | |||
| <T extends Response, SELF extends AbstractRuleWithContentBuilder<T, SELF>> | |||
There was a problem hiding this comment.
Global comment: Maybe SELF should come first?
trustin
approved these changes
Jun 7, 2024
Dogacel
pushed a commit
to Dogacel/armeria
that referenced
this pull request
Jun 8, 2024
Motivation: See line#5684 for the motivation. Modifications: - Refactored builder classes to use the SELF type parameter for the builder's self-referencing methods. Result: - Reduced the need for cumbersome and error-prone method overrides. - (Breaking) These are all annotated with `@UnstableApi`. - `AbstractDnsResolverBuilder` is now `AbstractDnsResolverBuilder<SELF>` - `AbstractRuleBuilder` is now `AbstractRuleBuilder<SELF>` - `AbstractRuleWithContentBuilder` is now `AbstractRuleWithContentBuilder<SELF>` - `AbstractCircuitBreakerMappingBuilder` is now `AbstractCircuitBreakerMappingBuilder<SELF>` - `AbstractDynamicEndpointGroupBuilder` is now `AbstractDynamicEndpointGroupBuilder<SELF>` - `DynamicEndpointGroupSetters` is now `DynamicEndpointGroupSetters<SELF>` - `AbstractCuratorFrameworkBuilder` is now `AbstractCuratorFrameworkBuilder<SELF>`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
See #5684 for the motivation.
Modifications:
Result:
@UnstableApi.AbstractDnsResolverBuilderis nowAbstractDnsResolverBuilder<SELF>AbstractRuleBuilderis nowAbstractRuleBuilder<SELF>AbstractRuleWithContentBuilderis nowAbstractRuleWithContentBuilder<SELF>AbstractCircuitBreakerMappingBuilderis nowAbstractCircuitBreakerMappingBuilder<SELF>AbstractDynamicEndpointGroupBuilderis nowAbstractDynamicEndpointGroupBuilder<SELF>DynamicEndpointGroupSettersis nowDynamicEndpointGroupSetters<SELF>AbstractCuratorFrameworkBuilderis nowAbstractCuratorFrameworkBuilder<SELF>