Try enabling PTS for non-CI builds #5324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5324 +/- ##
===========================================
+ Coverage 0 73.93% +73.93%
- Complexity 0 20097 +20097
===========================================
Files 0 1730 +1730
Lines 0 74142 +74142
Branches 0 9461 +9461
===========================================
+ Hits 0 54820 +54820
- Misses 0 14841 +14841
- Partials 0 4481 +4481 ☔ View full report in Codecov by Sentry. |
jrhee17
changed the title
seonWKim
pushed a commit
to seonWKim/armeria
that referenced
this pull request
Dec 7, 2023
Motivation: We may be able to increase build speeds locally if we enable PTS for non-CI builds Modifications: - Added a PTS setting for tests if the CI field is not set - https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables Result: - Faster local builds <!-- Visit this URL to learn more about how to write a pull request description: https://armeria.dev/community/developer-guide#how-to-write-pull-request-description -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We may be able to increase build speeds locally if we enable PTS for non-CI builds
Modifications:
Result: