Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug where a connection may be not reused when using RetryingClient #5290

Merged
merged 11 commits into from
Nov 8, 2023

use ctx.eventLoop()

d73eabc
Select commit
Loading
Failed to load commit list.
Merged

Fix a bug where a connection may be not reused when using RetryingClient #5290

use ctx.eventLoop()
d73eabc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 8, 2023 in 0s

73.95% (+73.95%) compared to ff9f2e0

View this Pull Request on Codecov

73.95% (+73.95%) compared to ff9f2e0

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff9f2e0) 0.00% compared to head (d73eabc) 73.95%.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #5290       +/-   ##
===========================================
+ Coverage        0   73.95%   +73.95%     
- Complexity      0    20104    +20104     
===========================================
  Files           0     1730     +1730     
  Lines           0    74139    +74139     
  Branches        0     9460     +9460     
===========================================
+ Hits            0    54831    +54831     
- Misses          0    14832    +14832     
- Partials        0     4476     +4476
Files Coverage Δ
...a/internal/client/DefaultClientRequestContext.java 90.90% <100.00%> (ø)

... and 1729 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov