Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore empty Gradle build scans and continue to upload #5130

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

ikhoon
Copy link
Contributor

@ikhoon ikhoon commented Aug 21, 2023

Motivation:

A build scan may fail to upload if a Gradle build is corrupted somehow.
If there is no scan data in .gradle/build-scan-data, ./gradlew buildScanPublishPrevious exits with 1, and then the subsequent commands will be halted.

Modifications:

  • Ignore failed upload build scan and continue to upload the next data
  • Use html_url for the workflow job

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1ce4c69) 74.30% compared to head (3346311) 74.31%.

❗ Current head 3346311 differs from pull request most recent head e94e3ae. Consider uploading reports for the commit e94e3ae to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5130   +/-   ##
=========================================
  Coverage     74.30%   74.31%           
- Complexity    19600    19601    +1     
=========================================
  Files          1682     1682           
  Lines         72260    72260           
  Branches       9242     9242           
=========================================
+ Hits          53695    53700    +5     
- Misses        14222    14223    +1     
+ Partials       4343     4337    -6     

see 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jrhee17 jrhee17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ikhoon 🙇 👍 🙇

Copy link
Member

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ikhoon ikhoon merged commit 69a0041 into line:main Aug 23, 2023
@ikhoon ikhoon deleted the handle-empty-build-scan branch August 23, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants