Fix to correctly leave Gradle build scan results as a comment #5126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: A pull request number fails to get retrived from a commit SHA. It was not a problem while testing the feature in the personal repo. Because that happens only when the commit is maded from a forked repository. For example, the PR number of line@529961c can be retrived by https://api.github.com/repos/minwoox/armeria/commits/529961c4a43fb884cf780421218de4f56f1aafcc/pulls but https://api.github.com/repos/line/armeria/commits/529961c4a43fb884cf780421218de4f56f1aafcc/pulls returns an empty array. Note that the oweners of the repository are diffrent. As a result, the scan results are not updated as a comment of a PR. https://github.com/line/armeria/blob/0cd7094b763e6c501b08e2cd44bb1835eaa46eea/.github/workflows/gradle-build-scan.yml#L90-L90 Modifications: - Prepend a pull request number to the artifact names of scan results. - Remove `get-pr-number-by-sha.ts` and its dependencies Result: Correctly update build scan results.
|
Let me merge this PR because the changes are clear and only CI workflows are modified. |
jrhee17
added a commit
to jrhee17/armeria
that referenced
this pull request
Aug 21, 2023
…line#5126)" This reverts commit 1ce4c69.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
A pull request number fails to get retrieved from a commit SHA of a PR. Interestingly, it was not a problem while testing the feature in the personal repo. Because that happens only when the commit is made from a forked repository.
For example, the PR information of 529961c is retrieved by https://api.github.com/repos/minwoox/armeria/commits/529961c4a43fb884cf780421218de4f56f1aafcc/pulls but https://api.github.com/repos/line/armeria/commits/529961c4a43fb884cf780421218de4f56f1aafcc/pulls returns an empty array. Note that the owners of the repository are different.
As a result, the scan results are not updated as a comment of a PR.
armeria/.github/workflows/gradle-build-scan.yml
Line 90 in 0cd7094
Modifications:
get-pr-number-by-sha.tsand its dependenciesResult:
Correctly update build scan results.