Fix a bug where builders of LogFormatter return internal classes
#4975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: `TextLogFormatterBuilder.build()` and `JsonLogFormatterBuilder.build()` return package-private classes that cause compliation errors when using them in different packages. Modifications: - Make `TextLogFormatterBuilder.build()` and `JsonLogFormatterBuilder.build()` return `LogFormatter` instead of the internal classes. Result: You can no longer see compilation errors when using `TextLogFormatterBuilder.build()` and `JsonLogFormatterBuilder.build()`.
minwoox
reviewed
Jun 21, 2023
core/src/main/java/com/linecorp/armeria/common/logging/JsonLogFormatterBuilder.java
Outdated
Show resolved
Hide resolved
trustin
approved these changes
Jun 21, 2023
|
@minwoox PTAL. 🙇♂️ |
minwoox
approved these changes
Jun 21, 2023
|
Thanks for quick fix |
It was not you but me. 🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
TextLogFormatterBuilder.build()andJsonLogFormatterBuilder.build()return package-private classes that cause compilation errors when using them in different packages.Modifications:
TextLogFormatterBuilder.build()andJsonLogFormatterBuilder.build()returnLogFormatterinstead of the internal classes.Result:
You can no longer see compilation errors when using
TextLogFormatterBuilder.build()andJsonLogFormatterBuilder.build().