Complete DefaultClientRequestContext.whenIntialized() after fully initializing a context

[ikhoon]

Motivation:

LazyDynamicEndpointGroupTest.emptyEndpoint() sometimes failed in CI
builds. #3381 It expects to fail the test with EmptyEndpointException,
however, it fails with ClosedStreamException.

After digging the issue, I find out that there is a race in whenInitialized.
If the acquiredEventLoop.execute() is executed immediately and completed earlier than
returning the method,

armeria/core/src/main/java/com/linecorp/armeria/client/DefaultClientRequestContext.java

Lines 307 to 309 in d4880fe

	acquiredEventLoop.execute(() -> finalWhenInitialized.complete(success));
	}
	return finalWhenInitialized;

the callbacks of ctx.whenInitialized() will be invoked before a RequestLog
is completed.

armeria/grpc/src/main/java/com/linecorp/armeria/internal/client/grpc/ArmeriaClientCall.java

Lines 337 to 348 in 207c5e0

	if (log.isComplete()) {
	// Completed already; no need to send anymore.
	return;
	}
	try {
	if (!log.isAvailable(RequestLogProperty.REQUEST_CONTENT)) {
	ctx.logBuilder().requestContent(GrpcLogUtil.rpcRequest(method, simpleMethodName(), message),
	null);
	}
	final ByteBuf serialized = marshaller.serializeRequest(message);
	req.write(requestFramer.writePayload(serialized));

As the req is closed already, the req.write() would be failed with
ClosedStreamException.

Modifications:

• Complete DefaultClientRequestContext.whenIntialized() after
  initContextAndExecuteWithFallback of ClientUtil

Result:

• You no longer see ClosedStreamException when an EndpointGroup is empty.
• Fixes Intermittent test failure: LazyDynamicEndpointGroupTest.emptyEndpoint() #3381

[codecov]

Codecov Report

Merging #3636 (6747b57) into master (7bf1873) will increase coverage by 0.10%.
The diff coverage is 87.55%.

@@             Coverage Diff              @@
##             master    #3636      +/-   ##
============================================
+ Coverage     73.83%   73.94%   +0.10%     
- Complexity    14378    14530     +152     
============================================
  Files          1263     1266       +3     
  Lines         54874    55349     +475     
  Branches       7021     7103      +82     
============================================
+ Hits          40518    40929     +411     
- Misses        10786    10801      +15     
- Partials       3570     3619      +49     

Impacted Files	Coverage Δ
...ava/com/linecorp/armeria/client/ClientFactory.java	65.33% <ø> (ø)
...necorp/armeria/client/DecoratingClientFactory.java	37.03% <0.00%> (-1.43%)	⬇️
.../linecorp/armeria/client/Http1ResponseDecoder.java	66.26% <0.00%> (-0.41%)	⬇️
...om/linecorp/armeria/common/ContextAwareLogger.java	4.74% <0.00%> (-0.03%)	⬇️
.../java/com/linecorp/armeria/common/HttpRequest.java	80.37% <ø> (+2.02%)	⬆️
...java/com/linecorp/armeria/common/HttpResponse.java	93.47% <ø> (-0.49%)	⬇️
...inecorp/armeria/server/AbstractBindingBuilder.java	86.27% <ø> (ø)
...java/com/linecorp/armeria/server/RouteBuilder.java	89.47% <ø> (ø)
.../linecorp/armeria/common/util/EventLoopGroups.java	42.85% <25.00%> (-2.31%)	⬇️
...com/linecorp/armeria/common/auth/OAuth1aToken.java	68.91% <70.58%> (+0.42%)	⬆️
... and 98 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49594e9...6747b57. Read the comment docs.

[minwoox]

What a brilliant!

[trustin]

Nice find!

[trustin]

Thanks, @ikhoon !