Respect SubscriptionOption.WITH_POOLED_OBJECTS in PublisherBasedStreamMessage
#3617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reamMessage`
Motivation:
The implementations of `StreamMessage` in Armeria are in charge of releasing the pooled objects
when the subscriber subscribes without the `WITH_POOLED_OBJECTS` option.
However, `PublisherBasedStreamMessage` currentyly ignores `WITH_POOLED_OBJECTS` option.
We should respect that so that the subscriber does not have to deal with when it does not specify
`WITH_POOLED_OBJECTS` option.
Modifications:
- Respect `SubscriptionOption.WITH_POOLED_OBJECTS` in `PublisherBasedStreamMessage`.
- The Subscriber who does not specify `WITH_POOLED_OBJECTS` when subscribing does not have to release
the pooled objects by itself anymore.
Result:
- Close line#3608
- You can use Spring WebFlux integration with compression enabled.
- You do not have to release the pooled objects when subscribing `PublisherBasedStreamMessage`
without `WITH_POOLED_OBJECTS` option.
|
Thanks, @ikhoon who gave this idea to fix the leak. 😄 |
ikhoon
approved these changes
Jun 7, 2021
trustin
approved these changes
Jun 14, 2021
| @@ -223,6 +223,7 @@ ad | |||
| ad.jp | |||
| adac | |||
| adachi.tokyo.jp | |||
| adimo.co.uk | |||
trustin
changed the title
SubscriptionOption.WITH_POOLED_OBJECTS in `PublisherBasedSt…SubscriptionOption.WITH_POOLED_OBJECTS in PublisherBasedStreamMessage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…reamMessage`
Motivation:
The implementations of
StreamMessagein Armeria are in charge of releasing the pooled objectswhen the subscriber subscribes without the
WITH_POOLED_OBJECTSoption.However,
PublisherBasedStreamMessagecurrentyly ignoresWITH_POOLED_OBJECTSoption.We should respect that so that the subscriber does not have to deal with when it does not specify
WITH_POOLED_OBJECTSoption.Modifications:
SubscriptionOption.WITH_POOLED_OBJECTSinPublisherBasedStreamMessage.WITH_POOLED_OBJECTSwhen subscribing does not have to releasethe pooled objects by itself anymore.
Result:
LEAK: ByteBuf.release()when "server.compression.enabled=true" #3608PublisherBasedStreamMessagewithout
WITH_POOLED_OBJECTSoption.