-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a util method to warm up EventLoopGroup
#3610
Conversation
core/src/main/java/com/linecorp/armeria/common/util/EventLoopGroups.java
Outdated
Show resolved
Hide resolved
…roups.java Co-authored-by: Trustin Lee <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## master #3610 +/- ##
============================================
- Coverage 73.89% 73.83% -0.06%
- Complexity 14367 14378 +11
============================================
Files 1260 1263 +3
Lines 54819 54878 +59
Branches 7021 7021
============================================
+ Hits 40507 40521 +14
- Misses 10732 10794 +62
+ Partials 3580 3563 -17
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! @kezhenxu94
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Motivation:
Netty's event loop threads are spawned lazily, i.e. they are created
on the first task is scheduled on. A user sometimes wants to ensure
the event loop threads are started when the server starts up.
Modifications:
EventLoopGroups.warmUp()
Result:
EventLoops.warmUp(EventLoopGroup)
#3363