Respond 408 status when the server didn't receive request fully until it's timed out #5579
Labels
Comments
|
Can I work on this? |
|
Hi, @thachlp! |
Thanks |
minwoox
added a commit
to minwoox/armeria
that referenced
this issue
May 16, 2024
…lly. Motivation: Currently, the server always responds with a 503 status if a `RequestTimeoutException` is raised. However, according to the RFC 9110, the correct response in this case should be a 408 status code. https://httpwg.org/specs/rfc9110.html#status.408 ``` The 408 (Request Timeout) status code indicates that the server did not receive a complete request message within the time that it was prepared to wait. ``` Modification: - Introduced `DecodedHttpRequest.isNormallyClosed()` to check if the request was received fully. - Updated the server to send a 408 response when a request times out and the service didn't receive the request fully. Result: - The server now returns a 408 status if a service didn't receive the request fully and the request times out. - Issue line#5579 has been closed.
|
@thachlp, Sorry I had to do this by myself because it's more complicated than I initially thought. 😓 |
It is fine, thank you for information 🙇 |
minwoox
added a commit
that referenced
this issue
May 31, 2024
…lly (#5680) Motivation: Currently, the server always responds with a 503 status if a `RequestTimeoutException` is raised. However, according to the RFC 9110, the correct response in this case should be a 408 status code. https://httpwg.org/specs/rfc9110.html#status.408 ``` The 408 (Request Timeout) status code indicates that the server did not receive a complete request message within the time that it was prepared to wait. ``` Modification: - Introduced `DecodedHttpRequest.isNormallyClosed()` to check if the request was received fully. - Updated the server to send a 408 response when a request times out and the service didn't receive the request fully. Result: - The server now returns a 408 status if a service didn't receive the request fully and the request times out. - Issue #5579 has been closed.
Dogacel
pushed a commit
to Dogacel/armeria
that referenced
this issue
Jun 8, 2024
…lly (line#5680) Motivation: Currently, the server always responds with a 503 status if a `RequestTimeoutException` is raised. However, according to the RFC 9110, the correct response in this case should be a 408 status code. https://httpwg.org/specs/rfc9110.html#status.408 ``` The 408 (Request Timeout) status code indicates that the server did not receive a complete request message within the time that it was prepared to wait. ``` Modification: - Introduced `DecodedHttpRequest.isNormallyClosed()` to check if the request was received fully. - Updated the server to send a 408 response when a request times out and the service didn't receive the request fully. Result: - The server now returns a 408 status if a service didn't receive the request fully and the request times out. - Issue line#5579 has been closed.
|
Closed by #5680 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, we always respond with 503 if a
RequestTimeoutExceptionis raised.However, we should send 408 status if the server didn't receive the request fully.
https://httpwg.org/specs/rfc9110.html#status.408
Related: #5572
The text was updated successfully, but these errors were encountered: