Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ArmeriaSettings.ip and add ArmeriaSettings.address #4597

Closed
minwoox opened this issue Dec 30, 2022 · 1 comment · Fixed by #4598
Closed

Deprecate ArmeriaSettings.ip and add ArmeriaSettings.address #4597

minwoox opened this issue Dec 30, 2022 · 1 comment · Fixed by #4598

Comments

@minwoox
Copy link
Contributor

minwoox commented Dec 30, 2022

Users can specify an IP address of Armeria server via a Spring property file:

/**
* IP address to bind to. If not set, will bind to all addresses, e.g. {@code 0.0.0.0}.
*/
@Nullable
private String ip;

It only takes an IP address so if a hostname is specified, Armeria throws an exception:

However, Spring allows Users to specify a hostname because Spring converts the input to an InetAddress.
So we need to also allow users to specify a hostname by

  • adding ArmeriaSettings.address whose type is InetAddress
  • deprecating ArmeriaSettings.ip
@minwoox
Copy link
Contributor Author

minwoox commented Dec 30, 2022

cc @kojilin

minwoox pushed a commit that referenced this issue Jan 12, 2023
Motivation:

Spring allows Users to specify a hostname because Spring converts the input to an InetAddress.
So we need to also allow users to specify a hostname.

Modifications:

- adding ArmeriaSettings.address whose type is InetAddress
- deprecating ArmeriaSettings.ip

Result:

- Closes #4597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant