chore: update to Go 1.21 #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamestelfer
commented
Oct 26, 2023
| @@ -10,4 +10,5 @@ jobs: | |||
| - name: golangci-lint | |||
| uses: reviewdog/action-golangci-lint@v2 | |||
| with: | |||
| go_version_file: "go.mod" | |||
There was a problem hiding this comment.
Note: reviewdog uses snake case for its arguments.
jamestelfer
commented
Oct 26, 2023
There was a problem hiding this comment.
Gonna be honest, don't really understand these changes.
There was a problem hiding this comment.
Might change between go versions, but should be backwards and forwards compatible.
lindell
approved these changes
Oct 26, 2023
|
Included in release v0.48.0 🎉 |
This was referenced Jan 6, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Updates build to use Go 1.21, and tries to ensure CI workflows are operating against the version of Go currently used by
go.mod.Go 1.21 includes various enhancements including new APIs for
slice, along with a variety of fixes.What issue does it fix
No specific issue, just looking to be able to use some newer APIs.
Notes for the reviewer
Some of the workflows only execute on
master. The changes appear safe, and any issues could potentially be fixed in a "fast follow" response.Checklist