Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quiet the quickstart pip install #421

Merged
merged 1 commit into from
Apr 1, 2024
Merged

quiet the quickstart pip install #421

merged 1 commit into from
Apr 1, 2024

Conversation

dougbrn
Copy link
Collaborator

@dougbrn dougbrn commented Mar 29, 2024

I noticed that the pip install command in the quickstart guide has a lot of output (potentially because we now use the magic command?). To address this, I've added the quiet flag. Alternatively we could opt to return to using !pip install lf-tape

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

Before [3321b58] After [5957a60] Ratio Benchmark (Parameter)
31.4±0.5ms 30.8±0.2ms 0.98 benchmarks.time_prune_sync_workflow
31.3±0.9ms 30.1±0.3ms 0.96 benchmarks.time_batch

Click here to view all benchmarks.

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.78%. Comparing base (3321b58) to head (8e12db3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #421   +/-   ##
=======================================
  Coverage   95.78%   95.78%           
=======================================
  Files          25       25           
  Lines        1755     1755           
=======================================
  Hits         1681     1681           
  Misses         74       74           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dougbrn dougbrn marked this pull request as ready for review March 29, 2024 18:49
@dougbrn dougbrn requested a review from nevencaplar March 29, 2024 18:49
Copy link
Member

@nevencaplar nevencaplar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I tried puting a semicolon at the end of juypter cell, but that does not stop terminal output being rendered.

@dougbrn dougbrn merged commit c4ae53b into main Apr 1, 2024
10 checks passed
@dougbrn dougbrn deleted the quiet_install branch April 4, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants