Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor docs cleanups for TAPE #414

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Minor docs cleanups for TAPE #414

merged 4 commits into from
Mar 28, 2024

Conversation

wilsonbb
Copy link
Collaborator

@wilsonbb wilsonbb commented Mar 28, 2024

A series of minor docs cleanups addressing small changes proposed in #372

The following changes are made:

  • When loading a time series object in what was formerly this section, add a sentence such as ``Note that this loads the data from all available bands’’
  • Changed Installing in the Quickstart to be an executable shell command to pip install TAPE
  • Demonstrate setting a random seed in Ensemble.smaple
  • Improves the plot in in From the ensemble
  • My PR includes a link to the issue that I am addressing

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

github-actions bot commented Mar 28, 2024

Before [19ff5ad] After [7292fe7] Ratio Benchmark (Parameter)
34.1±0.3ms 34.7±0.6ms 1.02 benchmarks.time_prune_sync_workflow
33.1±0.3ms 33.5±0.6ms 1.01 benchmarks.time_batch

Click here to view all benchmarks.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.77%. Comparing base (19ff5ad) to head (bad18b6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #414   +/-   ##
=======================================
  Coverage   95.77%   95.77%           
=======================================
  Files          25       25           
  Lines        1751     1751           
=======================================
  Hits         1677     1677           
  Misses         74       74           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wilsonbb wilsonbb requested a review from dougbrn March 28, 2024 18:28
@wilsonbb wilsonbb marked this pull request as ready for review March 28, 2024 18:28
@@ -12,12 +12,22 @@
"cell_type": "markdown",
Copy link
Collaborator

@dougbrn dougbrn Mar 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have this be %pip install lf-tape


Reply via ReviewNB

docs/tutorials/common_data_operations.ipynb Show resolved Hide resolved
Copy link
Collaborator

@dougbrn dougbrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small suggestions, but overall this looks good!

@wilsonbb wilsonbb merged commit 60f12c3 into main Mar 28, 2024
10 checks passed
@dougbrn dougbrn deleted the minor_docs branch April 4, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants