-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce LSST Focus in TAPE Intro Docs #407
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #407 +/- ##
=======================================
Coverage 95.53% 95.53%
=======================================
Files 25 25
Lines 1702 1702
=======================================
Hits 1626 1626
Misses 76 76 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, imo that one small change and it is ready
README.md
Outdated
- Enable efficient and scalable evaluation of algorithms on time-domain data | ||
- Enable ease of access to TimeSeries objects in LSST |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let us again call it time-domain data here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also agree this looks good, pending Neven's suggestion
Change Description
Changes the README and readthedocs intro page to deemphasize TAPE's goals of working with LSST timeseries data. While these are still noted as part of the motivation of the project, as noted in #365 the current emphasis may cause users to not see TAPE as useful for other big surveys.
While here also changed the default recommended python version from 3.10 to 3.11 as was requested in #372