Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce LSST Focus in TAPE Intro Docs #407

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Reduce LSST Focus in TAPE Intro Docs #407

merged 3 commits into from
Mar 19, 2024

Conversation

wilsonbb
Copy link
Collaborator

Change Description

Changes the README and readthedocs intro page to deemphasize TAPE's goals of working with LSST timeseries data. While these are still noted as part of the motivation of the project, as noted in #365 the current emphasis may cause users to not see TAPE as useful for other big surveys.

While here also changed the default recommended python version from 3.10 to 3.11 as was requested in #372

Copy link

github-actions bot commented Mar 18, 2024

Before [8f0c7b7] After [9d0faf0] Ratio Benchmark (Parameter)
46.2±0.2ms 46.5±0.5ms 1.01 benchmarks.time_prune_sync_workflow
44.8±0.2ms 43.1±0.1ms 0.96 benchmarks.time_batch

Click here to view all benchmarks.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.53%. Comparing base (8f0c7b7) to head (443f9e6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #407   +/-   ##
=======================================
  Coverage   95.53%   95.53%           
=======================================
  Files          25       25           
  Lines        1702     1702           
=======================================
  Hits         1626     1626           
  Misses         76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wilsonbb wilsonbb changed the title Change Intro Docs to Be Less LSST-focused Reduce LSST Focus in TAPE Intro Docs Mar 18, 2024
@wilsonbb wilsonbb marked this pull request as ready for review March 18, 2024 18:24
@wilsonbb wilsonbb requested review from nevencaplar and dougbrn March 18, 2024 18:24
Copy link
Member

@nevencaplar nevencaplar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, imo that one small change and it is ready

README.md Outdated
- Enable efficient and scalable evaluation of algorithms on time-domain data
- Enable ease of access to TimeSeries objects in LSST
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us again call it time-domain data here

Copy link
Collaborator

@dougbrn dougbrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also agree this looks good, pending Neven's suggestion

@wilsonbb wilsonbb merged commit 0c7a044 into main Mar 19, 2024
10 checks passed
@dougbrn dougbrn deleted the small_fixes branch April 4, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants