Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add to column selection example #388

Merged
merged 1 commit into from
Mar 14, 2024
Merged

add to column selection example #388

merged 1 commit into from
Mar 14, 2024

Conversation

dougbrn
Copy link
Collaborator

@dougbrn dougbrn commented Mar 14, 2024

Change Description

  • My PR includes a link to the issue that I am addressing

Addresses #369. I accidentally pushed the first commit of this directly to main. This PR is meant to put a reviewers eyes on the section, and also formally retrigger a readthedocs build.

Solution Description

Code Quality

  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

  • I have added a function that requires a sync_tables command, and have added the neccesary sync_tables call

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

Build/CI Change Checklist

  • If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
  • If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

  • Any new or updated docstrings use the NumPy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover any changes
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

Before [f336b09] After [50d6b6a] Ratio Benchmark (Parameter)
51.6±2ms 50.8±0.9ms 0.98 benchmarks.time_prune_sync_workflow
49.1±0.4ms 46.7±0.7ms 0.95 benchmarks.time_batch

Click here to view all benchmarks.

@dougbrn dougbrn marked this pull request as ready for review March 14, 2024 17:24
@dougbrn dougbrn requested a review from nevencaplar March 14, 2024 17:25
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.53%. Comparing base (f336b09) to head (1789dbd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #388   +/-   ##
=======================================
  Coverage   95.53%   95.53%           
=======================================
  Files          25       25           
  Lines        1702     1702           
=======================================
  Hits         1626     1626           
  Misses         76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nevencaplar nevencaplar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact that when re-reading the documentation I could not see where the problem was means that the pull to the main was good.

@dougbrn dougbrn merged commit ff09c8b into main Mar 14, 2024
13 checks passed
@dougbrn dougbrn deleted the column_selection branch April 4, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants