Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ColumnMapper Known Mappings and Add Hipscat support #378

Merged
merged 6 commits into from
Feb 15, 2024

Conversation

dougbrn
Copy link
Collaborator

@dougbrn dougbrn commented Feb 15, 2024

Change Description

Resolves #185, updates the initial ZTF mapping to use columns from the hipscatted ZTF source catalog. Adds a hipscat kwarg to indicate whether to use the _hipscat_index as the chosen id column, and adds an initial mapper for pan-starrs.

  • My PR includes a link to the issue that I am addressing

Solution Description

Code Quality

  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

  • I have added a function that requires a sync_tables command, and have added the neccesary sync_tables call

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

Build/CI Change Checklist

  • If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
  • If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

  • Any new or updated docstrings use the NumPy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover any changes
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

@dougbrn dougbrn changed the title update ztf map; add hipscat kwarg; add ps1 map Update ColumnMapper Known Mappings and Add Hipscat support Feb 15, 2024
Copy link

github-actions bot commented Feb 15, 2024

Before [db3ac53] After [62b10d3] Ratio Benchmark (Parameter)
49.1±2ms 52.5±0.6ms 1.07 benchmarks.time_batch
54.4±3ms 52.9±3ms 0.97 benchmarks.time_prune_sync_workflow

Click here to view all benchmarks.

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (db3ac53) 95.40% compared to head (8499562) 95.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
+ Coverage   95.40%   95.59%   +0.18%     
==========================================
  Files          25       25              
  Lines        1698     1702       +4     
==========================================
+ Hits         1620     1627       +7     
+ Misses         78       75       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dougbrn dougbrn marked this pull request as ready for review February 15, 2024 22:19
@dougbrn dougbrn requested a review from wilsonbb February 15, 2024 22:19
"""test a known mapping"""
cmap = ColumnMapper()

if map_id == "Grundor":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol at Grundor

@dougbrn dougbrn merged commit b698d38 into main Feb 15, 2024
13 checks passed
@dougbrn dougbrn deleted the known_column_maps branch April 4, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ColumnMapper Known Mappings
2 participants