Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI on all PRs #345

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Run CI on all PRs #345

merged 1 commit into from
Jan 16, 2024

Conversation

dougbrn
Copy link
Collaborator

@dougbrn dougbrn commented Jan 16, 2024

Change Description

Addresses #299. Switched the unit tests, documentation building, and linting to be on all branches. Opted not to for ASV benchmarking, as I don't believe we would want to save benchmarking results until code on the main branch is being affected? Tested this with a demo PR (#346), can see that the CI has been triggered.

  • My PR includes a link to the issue that I am addressing

Solution Description

Code Quality

  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

  • I have added a function that requires a sync_tables command, and have added the neccesary sync_tables call

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

Build/CI Change Checklist

  • If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
  • If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

  • Any new or updated docstrings use the NumPy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover any changes
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

@dougbrn dougbrn changed the title Ci on all pr Run CI on all PRs Jan 16, 2024
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9f03fe9) 95.15% compared to head (8dfbba8) 95.15%.

Additional details and impacted files
@@              Coverage Diff               @@
##           move_coalesce     #345   +/-   ##
==============================================
  Coverage          95.15%   95.15%           
==============================================
  Files                 24       24           
  Lines               1631     1631           
==============================================
  Hits                1552     1552           
  Misses                79       79           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dougbrn dougbrn changed the base branch from move_coalesce to main January 16, 2024 18:21
@dougbrn dougbrn marked this pull request as ready for review January 16, 2024 18:22
@dougbrn dougbrn requested a review from hombit January 16, 2024 18:25
Copy link
Contributor

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dougbrn dougbrn merged commit f69be16 into main Jan 16, 2024
18 of 19 checks passed
@dougbrn dougbrn deleted the ci_on_all_pr branch February 8, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants