Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Python Project Template v1.4.5; Integrate with ASV Benchmarking #340

Merged
merged 6 commits into from
Jan 2, 2024

Conversation

dougbrn
Copy link
Collaborator

@dougbrn dougbrn commented Jan 2, 2024

The vast majority of lines added/removed here are from the copier update command (grabbing the latest and greatest from ppt 1.4.5). This PR adds a few starter benchmarks for TAPE ASV integration. The github-actions comment below demonstrates that the PR comparison workflow is working as expected.

However, I don't think there's a way to test the gh-pages deployment until this gets merged into main, based on that I would like to try to merge this with a minimal benchmarking suite, verify whether the page deployment works as expected, and then build out the benchmarking suite in a later PR.

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e5404a6) 94.66% compared to head (58f79d7) 94.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #340   +/-   ##
=======================================
  Coverage   94.66%   94.66%           
=======================================
  Files          24       24           
  Lines        1556     1556           
=======================================
  Hits         1473     1473           
  Misses         83       83           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 2, 2024

Before [e5404a6] After [a1d320f] Ratio Benchmark (Parameter)
39.8±0.3ms 39.3±0.6ms 0.99 benchmarks.time_batch
42.4±0.3ms 41.8±0.2ms 0.99 benchmarks.time_prune_sync_workflow

Click here to view all benchmarks.

@dougbrn dougbrn changed the title update to ppt 1.4.5 Update to Python Project Template v1.4.5; Integrate with ASV Benchmarking Jan 2, 2024
@dougbrn dougbrn marked this pull request as ready for review January 2, 2024 21:23
@dougbrn dougbrn requested a review from drewoldag January 2, 2024 21:24
benchmarks/benchmarks.py Outdated Show resolved Hide resolved
Copy link
Contributor

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me. Neither of the comments that I left should be considered blockers.

@dougbrn dougbrn merged commit 3b3790b into main Jan 2, 2024
13 checks passed
@dougbrn dougbrn deleted the update_ppt_for_asv branch January 2, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants