-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Python Project Template v1.4.5; Integrate with ASV Benchmarking #340
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #340 +/- ##
=======================================
Coverage 94.66% 94.66%
=======================================
Files 24 24
Lines 1556 1556
=======================================
Hits 1473 1473
Misses 83 83 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ok to me. Neither of the comments that I left should be considered blockers.
The vast majority of lines added/removed here are from the copier update command (grabbing the latest and greatest from ppt 1.4.5). This PR adds a few starter benchmarks for TAPE ASV integration. The github-actions comment below demonstrates that the PR comparison workflow is working as expected.
However, I don't think there's a way to test the gh-pages deployment until this gets merged into main, based on that I would like to try to merge this with a minimal benchmarking suite, verify whether the page deployment works as expected, and then build out the benchmarking suite in a later PR.