Adds ability to give a single float input to zero_point #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
==========================================
+ Coverage 92.57% 92.63% +0.05%
==========================================
Files 22 22
Lines 1132 1140 +8
==========================================
+ Hits 1048 1056 +8
Misses 84 84
☔ View full report in Codecov by Sentry. |
hombit
approved these changes
Sep 15, 2023
src/tape/ensemble.py
Outdated
| The name of the ensemble column containing the zero point | ||
| information for column transformation. | ||
| information for column transformation. Alternatively, a float zero |
There was a problem hiding this comment.
It may be my issue, but float zero point sounds a bit weird. Could we say something like
"The name of the ensemble column containing the zero point values. Alternatively, a single float number to apply for all fluxes."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by Pan-STARRS1 zero_point calculations. Currently, the zero_point needs to be a column of the source table. But it seems clear from some limited examples that users will often want to just provide a float here.