Fix how Ensemble.batch processes on=None/str #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #203 +/- ##
==========================================
+ Coverage 92.94% 92.95% +0.01%
==========================================
Files 20 20
Lines 1049 1051 +2
==========================================
+ Hits 975 977 +2
Misses 74 74
|
hombit
force-pushed
the
fix-ensemble-batch-on
branch
from
e2b5fae to
c6f367c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix of a little bug in
Ensemble.batch. However it would be nice to have better test coverage foronargument, which this PR does not provideCloses #202