Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move datasets tests to nested_pandas folder #77

Merged
merged 1 commit into from
May 10, 2024
Merged

Conversation

hombit
Copy link
Collaborator

@hombit hombit commented May 10, 2024

Change Description

  • My PR includes a link to the issue that I am addressing

Solution Description

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

Build/CI Change Checklist

  • If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
  • If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

  • Any new or updated docstrings use the NumPy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover any changes
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

@hombit hombit requested a review from dougbrn May 10, 2024 14:52
Copy link

Before [631787f] After [7c43e63] Ratio Benchmark (Parameter)
6.36±0.1ms 6.59±0.08ms 1.04 benchmarks.NestedFrameQuery.time_run
62.5±2ms 65.0±2ms 1.04 benchmarks.ReassignHalfOfNestedSeries.time_run
8.89±0.2ms 9.05±0.3ms 1.02 benchmarks.NestedFrameAddNested.time_run
280M 285M 1.02 benchmarks.ReassignHalfOfNestedSeries.peakmem_run
86M 85.8M 1 benchmarks.NestedFrameAddNested.peakmem_run
90M 89.8M 1 benchmarks.NestedFrameQuery.peakmem_run
88.2M 88.2M 1 benchmarks.NestedFrameReduce.peakmem_run
5.37±0.02ms 5.37±0.06ms 1 benchmarks.NestedFrameReduce.time_run
263M 259M 0.99 benchmarks.AssignSingleDfToNestedSeries.peakmem_run
34.5±4ms 32.3±2ms 0.94 benchmarks.AssignSingleDfToNestedSeries.time_run

Click here to view all benchmarks.

Copy link
Collaborator

@dougbrn dougbrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@hombit hombit merged commit c7612af into main May 10, 2024
9 checks passed
@hombit hombit deleted the mv-test-detasets branch May 10, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants