Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add from_flat #123

Merged
merged 4 commits into from
Jul 17, 2024
Merged

add from_flat #123

merged 4 commits into from
Jul 17, 2024

Conversation

dougbrn
Copy link
Collaborator

@dougbrn dougbrn commented Jul 16, 2024

Change Description

Resolves #112

  • My PR includes a link to the issue that I am addressing

Solution Description

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Copy link

github-actions bot commented Jul 16, 2024

Before [3cd3baa] <v0.1.2> After [1102017] Ratio Benchmark (Parameter)
9.17±0.1ms 9.24±0.06ms 1.01 benchmarks.NestedFrameAddNested.time_run
1.11±0.01ms 1.12±0.01ms 1.01 benchmarks.NestedFrameReduce.time_run
86.9M 86.7M 1 benchmarks.NestedFrameAddNested.peakmem_run
6.36±0.08ms 6.37±0.1ms 1 benchmarks.NestedFrameQuery.time_run
90.1M 90.1M 1 benchmarks.NestedFrameReduce.peakmem_run
32.0±3ms 31.6±3ms 0.99 benchmarks.AssignSingleDfToNestedSeries.time_run
266M 261M 0.98 benchmarks.AssignSingleDfToNestedSeries.peakmem_run
93.3M 91.1M 0.98 benchmarks.NestedFrameQuery.peakmem_run
283M 278M 0.98 benchmarks.ReassignHalfOfNestedSeries.peakmem_run
61.6±3ms 59.1±2ms 0.96 benchmarks.ReassignHalfOfNestedSeries.time_run

Click here to view all benchmarks.

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.44%. Comparing base (3cd3baa) to head (5762116).
Report is 48 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #123   +/-   ##
=======================================
  Coverage   99.43%   99.44%           
=======================================
  Files          14       14           
  Lines         889      898    +9     
=======================================
+ Hits          884      893    +9     
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dougbrn dougbrn marked this pull request as ready for review July 16, 2024 22:27
@dougbrn dougbrn requested a review from hombit July 16, 2024 22:27
Copy link
Collaborator

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Please find a minor doc suggestion

src/nested_pandas/nestedframe/core.py Outdated Show resolved Hide resolved
@dougbrn dougbrn merged commit bcaf1b8 into main Jul 17, 2024
11 checks passed
@dougbrn dougbrn deleted the nesting_from_flat branch July 17, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create NestedPandas from a flat source table assuming some columns to be object columns
2 participants