Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move config parameters to a different table so that we can define a dataloader easier #91

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

drewoldag
Copy link
Collaborator

Moving filter and crop_to to the [data_set] table in the default config to make defining the dataloader easier.

Now the pytorch ignite dataloader can be defined with **kwargs instead of a bunch of hardcoded config parameters.

…t config to make defining the dataloader easier.
@drewoldag drewoldag self-assigned this Oct 9, 2024
@drewoldag drewoldag linked an issue Oct 9, 2024 that may be closed by this pull request
@drewoldag drewoldag requested a review from mtauraso October 9, 2024 21:13
Copy link

github-actions bot commented Oct 9, 2024

Before [6b8d978] <v0.1> After [595e149] Ratio Benchmark (Parameter)
3.23±0.6s 2.67±1s ~0.83 benchmarks.time_computation
3k 3.79k 1.26 benchmarks.mem_list

Click here to view all benchmarks.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 35.55%. Comparing base (6b8d978) to head (4325f98).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/fibad/pytorch_ignite.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #91   +/-   ##
=======================================
  Coverage   35.55%   35.55%           
=======================================
  Files          18       18           
  Lines         869      869           
=======================================
  Hits          309      309           
  Misses        560      560           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drewoldag drewoldag merged commit dad7062 into main Oct 15, 2024
8 checks passed
@drewoldag drewoldag deleted the issue/89/move-keys-in-config branch October 15, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move filters and crop_to to the [data_set] table in the default config
1 participant