Adding user-specified cutout crop size. #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtauraso
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 43.86% 46.63% +2.76%
==========================================
Files 16 16
Lines 554 579 +25
==========================================
+ Hits 243 270 +27
+ Misses 311 309 -2 ☔ View full report in Codecov by Sentry. |
aritraghsh09
approved these changes
Aug 27, 2024
| f"HSCDataSet in {self.path} has the wrong group of filters for object {object_id}." | ||
| ) | ||
| logger.warning(f"Dropping object {object_id} from the dataset.") | ||
| msg = f"HSCDataSet in {self.path} has the wrong group of filters for object {object_id}." |
There was a problem hiding this comment.
Might be useful to mention that we are dropping this object explicitly
mtauraso
commented
Aug 27, 2024
This was referenced Aug 27, 2024
- Objects who have any cutouts not capable of providing enough pixels are pruned - data_loader:crop_to is the config where pixel values are specified - Not providing the config gives you the old auto-detect behavior where the largest size that will work for all images in the data path is chosen.
mtauraso
force-pushed
the
issue/35/cutout-interface-cleanup
branch
from
982e502 to
9cd3680
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR is based on #33 If you are reviewing review that one first.
Once PR 33 is merged the diff view on this will get much easier. For now look at the last commit's diff only (bc75191)
largest size that will work for all images in the data path is chosen.