Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting file names to start with object_id #26

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

mtauraso
Copy link
Collaborator

This change is pretty straightforward.

@mtauraso mtauraso self-assigned this Aug 14, 2024
@mtauraso mtauraso changed the title Setting file names to be by object_id Setting file names to start with object_id Aug 14, 2024
@mtauraso mtauraso linked an issue Aug 14, 2024 that may be closed by this pull request
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.24%. Comparing base (7bfb7db) to head (5e1f928).
Report is 2 commits behind head on main.

Files Patch % Lines
src/fibad/download.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   39.45%   39.24%   -0.22%     
==========================================
  Files          10       10              
  Lines         185      186       +1     
==========================================
  Hits           73       73              
- Misses        112      113       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Before [7bfb7db] After [86a5f11] Ratio Benchmark (Parameter)
1.24±2s 2.38±0.7s ~1.91 benchmarks.time_computation
3.56k 88 0.02 benchmarks.mem_list

Click here to view all benchmarks.

Copy link
Collaborator

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@mtauraso mtauraso merged commit fe75ed4 into main Aug 15, 2024
7 of 9 checks passed
@mtauraso mtauraso deleted the issue/24/object_id_file_names branch August 15, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downloader should name files by object_id in the fits file
3 participants