ISSUE-1307 Allow to specify secondary bucket suffix #1309
+535
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chibenwa
reviewed
Nov 15, 2024
...ice/src/main/java/com/linagora/tmail/blob/guice/SecondaryS3BlobStoreConfigurationReader.java
Outdated
Show resolved
Hide resolved
quantranhong1999
force-pushed
the
secondary-blob-store-bucket-name-prefix
branch
from
49e01b7
to
e73bc02
Compare
quantranhong1999
changed the title
|
|
||
| private Mono<Void> readFromPrimaryAndSaveToSecondary(BucketName bucketName, BlobId blobId) { | ||
| return Mono.from(primaryBlobStoreDAO.readReactive(bucketName, blobId)) | ||
| .flatMap(inputStream -> Mono.from(secondaryBlobStoreDAO.save(withSuffix(bucketName, secondaryBucketSuffix), blobId, inputStream))) |
There was a problem hiding this comment.
Suggested change
| .flatMap(inputStream -> Mono.from(secondaryBlobStoreDAO.save(withSuffix(bucketName, secondaryBucketSuffix), blobId, inputStream))) | |
| .flatMap(inputStream -> Mono.from(secondaryBlobStoreDAO.save(withSuffix(bucketName), blobId, inputStream))) |
hungphan227
approved these changes
Nov 15, 2024
Arsnael
approved these changes
Nov 15, 2024
chibenwa
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #1307