Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE-1307 Allow to specify secondary bucket suffix #1309

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ISSUE-1307 Allow to specify secondary bucket suffix #1309

wants to merge 2 commits into from
+535 −83

Conversation

quantranhong1999
Copy link
Member

resolve #1307

@quantranhong1999 quantranhong1999 self-assigned this Nov 15, 2024
@quantranhong1999 quantranhong1999 mentioned this pull request Nov 15, 2024
Open
@quantranhong1999 quantranhong1999 force-pushed the secondary-blob-store-bucket-name-prefix branch from 49e01b7 to e73bc02 Compare November 15, 2024 07:31
@quantranhong1999 quantranhong1999 changed the title ISSUE-1307 Allow to specify secondary bucket prefix ISSUE-1307 Allow to specify secondary bucket suffix Nov 15, 2024
quantranhong1999
quantranhong1999 commented Nov 15, 2024
View reviewed changes
...re/src/main/java/com/linagora/tmail/blob/secondaryblobstore/FailedBlobOperationListener.java Outdated

private Mono<Void> readFromPrimaryAndSaveToSecondary(BucketName bucketName, BlobId blobId) {
return Mono.from(primaryBlobStoreDAO.readReactive(bucketName, blobId))
.flatMap(inputStream -> Mono.from(secondaryBlobStoreDAO.save(withSuffix(bucketName, secondaryBucketSuffix), blobId, inputStream)))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.flatMap(inputStream -> Mono.from(secondaryBlobStoreDAO.save(withSuffix(bucketName, secondaryBucketSuffix), blobId, inputStream)))
.flatMap(inputStream -> Mono.from(secondaryBlobStoreDAO.save(withSuffix(bucketName), blobId, inputStream)))

quantranhong1999
quantranhong1999 commented Nov 15, 2024
View reviewed changes
Copy link
Member Author

@quantranhong1999 quantranhong1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explicit test about empty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hungphan227 hungphan227 hungphan227 approved these changes

@Arsnael Arsnael Arsnael approved these changes

@chibenwa chibenwa chibenwa approved these changes

Assignees

@quantranhong1999 quantranhong1999

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CNB] Add optional suffix for bucket names of secondary blob store
4 participants
@quantranhong1999 @chibenwa @Arsnael @hungphan227