Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TableDataEditor.js Updates #32

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Conversation

jattwood
Copy link
Contributor

  • Changed allowable number of columns from 12 to 24

- Changed allowable number of rows from 12 to 24
@abjerner
Copy link
Member

Hi @jattwood

This package is based on some code we had across different projects. I wasn't aware if this limitation in the code when converting our code to a package, and only found out about it recently. I had a chat about this with a coworker just last week, and our conclusion was to remove this entirely. I just haven't gotten around to updating the package yet.

The UI may not work that great as the table gets more columns, but this may among other things depend on the user's window width, so it's hard to know exactly at which column count should be the limit. And it's still possible to edit the table even though the user experience takes a hit as the column count grows. So let's just remove this limit entirely. Can you update your PR to reflect this?

@abjerner abjerner added type/change-request Task is a request for a change, but not yet a feature. community/pr umbraco/v13 Issues and tasks related to Umbraco 13. labels Apr 30, 2024
-  Removed column count limit when adding new columns
@jattwood
Copy link
Contributor Author

Ok Done (I think). I also updated the V1 branch as well. Hope I did that correctly. Had some git issues earlier, but I think it should be ok. Still working off 11 currently but hope to migrate to 13 over the next few weeks.

Thanks!

@abjerner
Copy link
Member

abjerner commented May 1, 2024

Normally we can just cherry pick changes from one branch to another, but from a quick glance on GitHub, both your PRs look spot on 👍

I look into pushing a new release for either branch when I can find some time 😉

@jattwood
Copy link
Contributor Author

jattwood commented May 1, 2024

Ok great - much appreciated.

@jattwood
Copy link
Contributor Author

Any chance you would be able to merge and release this PR? Need to launch a site in the next week that's using the tables and it would be great to include this. Thanks!

@abjerner
Copy link
Member

Thanks a lot 👍

@abjerner abjerner added the release/13.0.1 Issues and tasks related to version 13.0.1. label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community/pr release/13.0.1 Issues and tasks related to version 13.0.1. type/change-request Task is a request for a change, but not yet a feature. umbraco/v13 Issues and tasks related to Umbraco 13.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants