go.mod: github.com/lima-vm/vz/v4 #5
Conversation
There was a problem hiding this comment.
I would also change
#define RAISE_REASON_MESSAGE \
"This may possibly be a bug due to library handling errors.\n" \
"I would appreciate it if you could report it to https://github.com/Code-Hex/vz/issues/new/choose\n\n" \
"Information: %@\n"
in virtualization_helper.h
Apart from this and the comment about the unrelated changes, the PR looks good to me.
| 1. If this is your first time, please read our contributor guidelines: https://github.com/Code-Hex/vz/blob/master/CONTRIBUTING.md | ||
| 2. Please create a new issue before creating this PR. However, You can continue it without creating issues if this PR fixes any documentations such as typo. | ||
| 3. Do not send Pull Requests for large (150 ~ lines) code changes. If so, I am not motivated to review your code. Basically, I write the code. | ||
| <!-- Thanks for sending a pull request! |
There was a problem hiding this comment.
This change and the removal of FUNDING.yml and CONTRIBUTING.md are not strictly related to the module renaming.
There was a problem hiding this comment.
Those files were specific to https://github.com/Code-Hex/vz and not appropriate for https://github.com/lima-vm/vz
There was a problem hiding this comment.
Yeah I understand, and I agree they should be removed/rewritten. For clarity, I would have put these changes in a separate commit with the explanation you just added.
done |
There was a problem hiding this comment.
Thanks, LGTM.
I think the part about the Wiki could be a bit clearer that the quoted text is from the upstream author (to make sure who "I" is in "Therefore, I have compiled the knowledge I have gathered so far into this wiki"). But I guess it is good enough.
Rename `github.com/Code-Hex/vz/v3` to `github.com/lima-vm/vz/v4` so that our fork can be consumed without the `replace` directive in `go.mod`. Fix issue 3 Also remove the contents specific to https://github.com/Code-Hex/vz (`CONTRIBUTING.md`, `FUNDING.yml`, etc.) Signed-off-by: Akihiro Suda <[email protected]>
done |
Rename
github.com/Code-Hex/vz/v3togithub.com/lima-vm/vz/v4so that our fork can be consumed without thereplacedirective ingo.mod.Fix #3
Also remove the contents specific to https://github.com/Code-Hex/vz (
CONTRIBUTING.md,FUNDING.yml, etc.)