Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of local environment variables instead of hard coding them in the… #6

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

lilstiffy
Copy link
Owner

… source code of the project

@lilstiffy lilstiffy self-assigned this Aug 20, 2024
Copy link

gitguardian bot commented Aug 20, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
8872817 Triggered Google API Key d6fdd7c app/src/main/AndroidManifest.xml View secret
8872817 Triggered Google API Key d6fdd7c gradle.properties View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@lilstiffy lilstiffy merged commit 68309bc into master Aug 20, 2024
0 of 2 checks passed
@lilstiffy lilstiffy deleted the tweak/env-variables branch August 20, 2024 08:37
@pwgit-create
Copy link

Grym du är Stefan! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants