Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix database check and creation #23

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Fix database check and creation #23

merged 2 commits into from
Jul 18, 2024

Conversation

lildude
Copy link
Owner

@lildude lildude commented Jul 18, 2024

As pointed out in #15, the addon can fail to start on some occassions. On closer examination, it's due to two schoolboy errors in the check for the DB and create it if it doesn't exist:

  1. It assumes the response will be in English
  2. It doesn't quote the DB name when creating the DB hence the syntax error when using DB names with a hyphen.

It also doesn't provide an accurate exit message when we encounter a problem.

This PR addresses that.

Fixes #15

@lildude lildude merged commit 64f0213 into main Jul 18, 2024
1 check passed
@lildude lildude deleted the fix-db-check branch July 18, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add-on does not start after migratoin
1 participant