Unique suffixes for items in defs sections of svg #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erent images in the same document (#1097)
|
Hey @pavelpykhtin But these changes will be overwritten by What if we utilise some plugin from svgo, like here |
|
Totally missed that script! Thanks for pointing out! Added prefixIds plugin into config. |
Automated changes by [create-pull-request](https://github.com/peter-evans/create-pull-request) GitHub action Co-authored-by: davydkov <[email protected]>
Automated changes by [create-pull-request](https://github.com/peter-evans/create-pull-request) GitHub action Co-authored-by: davydkov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@davydkov , linearGradient is defined in defs section of svg and thus is scoped to the whole document rather than that particular image. Added fix with unique suffix to defs content.
I'm not quite happy with the implementation. It feels wrong to do that many changes at once. Do you have some kind of import script for icons? Probably fix could be applied there?